Skip to content

fix(data): Fix GroupQueryPredicate Serialization for LastSyncMetadata stored syncExpression #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 8, 2025
Merged

fix(data): Fix GroupQueryPredicate Serialization for LastSyncMetadata stored syncExpression #3124

merged 17 commits into from
Sep 8, 2025

Conversation

@tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Sep 4, 2025 •
edited
Loading

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#3125

Also fixes #3043 by changing pragma usage

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner September 4, 2025 18:53
@tylerjroach
Copy link
Member Author

tylerjroach commented Sep 4, 2025

Fixes bug introduced here: #2937

@tylerjroach tylerjroach mentioned this pull request Sep 5, 2025
Closed
1 task
@codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 56.16438% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.26%. Comparing base (d9eb7a9) to head (c7c9ee9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   54.24%   54.26%   +0.02%     
==========================================
  Files        1038     1040       +2     
  Lines       32008    32062      +54     
  Branches     4703     4712       +9     
==========================================
+ Hits        17364    17400      +36     
- Misses      12805    12823      +18     
  Partials     1839     1839
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tylerjroach tylerjroach enabled auto-merge (squash) September 5, 2025 19:59
mattcreaser
mattcreaser reviewed Sep 8, 2025
View reviewed changes
@tylerjroach tylerjroach merged commit ed185fd into main Sep 8, 2025
17 of 18 checks passed
@tylerjroach tylerjroach deleted the tjroach/fix-predicate-serialization branch September 8, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcreaser mattcreaser mattcreaser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pragma_table_info Failed to initialize the local storage adapter for the DataStore plugin

2 participants

@tylerjroach @mattcreaser